Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amended if clauses for the Test if the ssh_elevate_credential differs from the ssh_credential #1586

Conversation

jhelmold
Copy link
Member

@jhelmold jhelmold commented Jun 24, 2021

What:

In manage_sql.c:
Amended the if clause for the Test if the ssh_credential
differs from the ssh_elevate_credential in functions
"create_target(...)" and "modify_target(...)".

Why:
The if clauses were not completely correct.

How did you test it:

Checklist:

In manage_sql.c:
  Amended the if clause for the Test if the ssh_credential
  differs from the ssh_elevate_credential in functions
  "create_target(...)" and "modify_target(...)".
@jhelmold jhelmold marked this pull request as ready for review June 24, 2021 06:30
@jhelmold jhelmold requested a review from a team as a code owner June 24, 2021 06:30
in manage_sql.c:
  Replaced the much to simple, erroneous if statement in function
  modify_target() by a more complex code.
…again.

In manage_sql.c, in function modify_target(...):
  Replaced the code for the check if the ssh_elevate_credential
  differs from the ssh_credential by a new one, that works in
  any case.
  Amended the check if there is a ssh_elevate_credential without
  a ssh_credential.
@timopollmeier timopollmeier merged commit 4562b15 into greenbone:gvmd-21.04 Jun 25, 2021
@timopollmeier timopollmeier added the backport-to-main This pull request will be ported to the master branch label Jun 25, 2021
timopollmeier added a commit that referenced this pull request Jun 28, 2021
Amended if clauses for the Test if the ssh_elevate_credential differs from the ssh_credential (backport #1586)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-main This pull request will be ported to the master branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants